flyingImer commented on code in PR #3729:
URL: https://github.com/apache/polaris/pull/3729#discussion_r3012330492
##########
polaris-core/src/main/java/org/apache/polaris/core/connection/iceberg/IcebergRestConnectionConfigInfoDpo.java:
##########
@@ -72,6 +87,12 @@ public String getRemoteCatalogName() {
}
// Add authentication-specific metadata (non-credential properties)
properties.putAll(getAuthenticationParameters().asIcebergCatalogProperties(credentialManager));
+ if (getConfigs().containsKey(GOOGLE_USER_PROJECT_HEADER_KEY)) {
Review Comment:
IIRC, getConfigs() is nullable per L64. This line could be led to NPE due to
GCP specific specifics. Would it make sense to normalize `configs` to
`Map.of()` (or at least null-check here) so existing/non-GCP external catalogs
keep working unchanged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
