dimas-b commented on code in PR #3729:
URL: https://github.com/apache/polaris/pull/3729#discussion_r3023513267
##########
polaris-core/src/test/java/org/apache/polaris/core/connection/ConnectionConfigInfoDpoTest.java:
##########
@@ -68,6 +68,7 @@ void testOAuthClientCredentialsParameters() throws
JsonProcessingException {
+ " \"connectionTypeCode\": 1,"
+ " \"uri\":
\"https://myorg-my_account.snowflakecomputing.com/polaris/api/catalog\",";
+ " \"remoteCatalogName\": \"my-catalog\","
+ + " \"additionalHeaders\": {},"
Review Comment:
nit: Since `additionalHeaders` is optional, could we avoid serializing their
empty/null values?
It's not a big deal, but excluding empty values could be easier on older
clients that may not expect the new entry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
