dimas-b commented on code in PR #3729:
URL: https://github.com/apache/polaris/pull/3729#discussion_r3012221653
##########
polaris-core/src/main/java/org/apache/polaris/core/connection/iceberg/IcebergRestConnectionConfigInfoDpo.java:
##########
@@ -72,6 +87,12 @@ public String getRemoteCatalogName() {
}
// Add authentication-specific metadata (non-credential properties)
properties.putAll(getAuthenticationParameters().asIcebergCatalogProperties(credentialManager));
+ if (getConfigs().containsKey(GOOGLE_USER_PROJECT_HEADER_KEY)) {
+ properties.put(
+ "header." + GOOGLE_USER_PROJECT_HEADER_KEY,
Review Comment:
Good point, @XJDKC !
However, for the sake of clarity: I believe the values in `getConfigs()`
come from `additionalHeaders` at the Polaris REST API layer. So, it makes sense
to use them only as headers, given the current state of this PR.
Still, if we wanted to allow more flexibility in defining
`IcebergRestConnectionConfigInfo`, I'd support that.
I suppose in this case the OpenAPI spec change in this PR will need to be
reworked too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
