rdblue commented on code in PR #3258:
URL: https://github.com/apache/parquet-java/pull/3258#discussion_r2248855094


##########
parquet-avro/src/main/java/org/apache/parquet/avro/AvroSchemaConverter.java:
##########
@@ -470,11 +470,8 @@ public Optional<Schema> visit(
               @Override
               public Optional<Schema> visit(
                   LogicalTypeAnnotation.VariantLogicalTypeAnnotation 
variantLogicalType) {
-                String name = parquetGroupType.getName();
-                List<Schema.Field> fields = new ArrayList<>();
-                fields.add(new Schema.Field("metadata", 
Schema.create(Schema.Type.BYTES)));
-                fields.add(new Schema.Field("value", 
Schema.create(Schema.Type.BYTES)));
-                return of(Schema.createRecord(name, null, namespace(name, 
names), false, fields));
+                return of(

Review Comment:
   Is that the behavior in production code or test code?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to