rdblue commented on code in PR #3258:
URL: https://github.com/apache/parquet-java/pull/3258#discussion_r2248852649
##########
parquet-avro/src/main/java/org/apache/parquet/avro/AvroVariantConverter.java:
##########
@@ -34,21 +35,27 @@
* Converter for Variant values.
*/
class AvroVariantConverter extends GroupConverter implements
VariantConverters.ParentConverter<VariantBuilder> {
+ private static final Schema VARIANT_SCHEMA =
SchemaBuilder.record("VariantRecord")
+ .fields()
+ .name("metadata")
+ .type()
+ .bytesType()
+ .noDefault()
+ .name("value")
+ .type()
+ .bytesType()
+ .noDefault()
+ .endRecord();
+
private final ParentValueContainer parent;
- private final Schema avroSchema;
private final GenericData model;
- private final int metadataPos;
- private final int valuePos;
Review Comment:
Why are all of these changes needed? I think this should continue to use the
schema that was passed in rather than replacing it with a different one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
