cashmand commented on code in PR #3258:
URL: https://github.com/apache/parquet-java/pull/3258#discussion_r2237240278
##########
parquet-avro/src/main/java/org/apache/parquet/avro/AvroVariantConverter.java:
##########
@@ -77,10 +78,12 @@ public void end() {
builder.appendNullIfEmpty();
- Object record = model.newRecord(null, avroSchema);
- model.setField(record, "metadata", metadataPos,
metadata.getEncodedBuffer());
- model.setField(record, "value", valuePos, builder.encodedValue());
- parent.add(record);
+ Variant variant = builder.build();
+ parent.add(variant);
Review Comment:
It sounds fine to me, I'd suggest getting @rdblue to approve. Maybe we want
to do something similar on the write side, where I think it also currently
expects a `metadata, value` pair from Avro rather than a Variant object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
