aihuaxu commented on code in PR #3258:
URL: https://github.com/apache/parquet-java/pull/3258#discussion_r2249033911
##########
parquet-avro/src/main/java/org/apache/parquet/avro/AvroVariantConverter.java:
##########
@@ -77,9 +84,9 @@ public void end() {
builder.appendNullIfEmpty();
- Object record = model.newRecord(null, avroSchema);
- model.setField(record, "metadata", metadataPos,
metadata.getEncodedBuffer());
- model.setField(record, "value", valuePos, builder.encodedValue());
+ Object record = model.newRecord(null, VARIANT_SCHEMA);
Review Comment:
Here what we are passing in the shredded schema which may/may not have
`value` or `typed_value` field.
But we want to generate a variant which maps to a record of `value` and
`metadata` fields, right?
<img width="693" height="136" alt="image"
src="https://github.com/user-attachments/assets/007b8b31-ea8b-4c47-acc5-57533a1a3d99";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
