rdblue commented on code in PR #3202:
URL: https://github.com/apache/parquet-java/pull/3202#discussion_r2069555833
##########
parquet-variant/src/test/java/org/apache/parquet/variant/TestVariantArray.java:
##########
@@ -20,104 +20,32 @@
import java.nio.ByteBuffer;
import java.nio.ByteOrder;
-import java.nio.charset.StandardCharsets;
-import java.security.SecureRandom;
import java.time.LocalDate;
-import java.util.*;
-import java.util.function.Consumer;
import org.junit.Assert;
import org.junit.Test;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
public class TestVariantArray {
private static final Logger LOG =
LoggerFactory.getLogger(TestVariantArray.class);
- private static final String RANDOM_CHARS =
"ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789";
- /** Random number generator for generating random strings */
- private static SecureRandom random = new SecureRandom(new byte[] {1, 2, 3,
4, 5});
-
- private static final ByteBuffer EMPTY_METADATA = ByteBuffer.wrap(new byte[]
{0b1});
-
- private static final byte[] VALUE_NULL = new byte[] {primitiveHeader(0)};
- private static final byte[] VALUE_BOOL = new byte[] {primitiveHeader(1)};
- private static final byte[] VALUE_INT = new byte[] {primitiveHeader(5),
(byte) 0xD2, 0x02, (byte) 0x96, 0x49};
+ private static final byte[] VALUE_NULL = new byte[]
{VariantTestUtil.primitiveHeader(0)};
+ private static final byte[] VALUE_BOOL = new byte[]
{VariantTestUtil.primitiveHeader(1)};
+ private static final byte[] VALUE_INT =
+ new byte[] {VariantTestUtil.primitiveHeader(5), (byte) 0xD2, 0x02,
(byte) 0x96, 0x49};
private static final byte[] VALUE_STRING =
- new byte[] {primitiveHeader(16), 0x07, 0x00, 0x00, 0x00, 'v', 'a', 'r',
'i', 'a', 'n', 't'};
+ new byte[] {VariantTestUtil.primitiveHeader(16), 0x07, 0x00, 0x00, 0x00,
'v', 'a', 'r', 'i', 'a', 'n', 't'};
Review Comment:
Overall, I think the tests are covering relevant encoding cases. I'd prefer
encoding and decoding tests in separate suites to be able to maintain them
better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
