rdblue commented on code in PR #3202:
URL: https://github.com/apache/parquet-java/pull/3202#discussion_r2069548151
##########
parquet-variant/src/test/java/org/apache/parquet/variant/TestVariantScalar.java:
##########
@@ -506,32 +730,54 @@ public void testTime() {
(byte) 0x00,
(byte) 0x00
}),
- EMPTY_METADATA);
- testVariant(value, v -> {
- checkType(v, VariantUtil.PRIMITIVE, Variant.Type.TIME);
+ VariantTestUtil.EMPTY_METADATA);
+ VariantTestUtil.testVariant(value, v -> {
+ VariantTestUtil.checkType(v, VariantUtil.PRIMITIVE, Variant.Type.TIME);
Assert.assertEquals(LocalTime.parse("23:59:59.123456"),
LocalTime.ofNanoOfDay(v.getLong() * 1_000));
});
}
@Test
- public void testTimestampNanos() {
+ public void testTimeBuilder() {
+ for (String timeStr : Arrays.asList(
+ "00:00:00.000000", "00:00:00.000120", "12:00:00.000000",
"12:00:00.002300", "23:59:59.999999")) {
+ VariantBuilder vb = new VariantBuilder(false);
+ long micros = LocalTime.parse(timeStr).toNanoOfDay() / 1_000;
+ vb.appendTime(micros);
Review Comment:
Should this allow or reject negative values?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
