rdblue commented on code in PR #3202:
URL: https://github.com/apache/parquet-java/pull/3202#discussion_r2069544783
##########
parquet-variant/src/test/java/org/apache/parquet/variant/TestVariantScalar.java:
##########
@@ -137,136 +118,248 @@ public void testNegativeLong() {
(byte) 0xFF,
(byte) 0xFF
}),
- EMPTY_METADATA);
- testVariant(value, v -> {
- checkType(v, VariantUtil.PRIMITIVE, Variant.Type.LONG);
+ VariantTestUtil.EMPTY_METADATA);
+ VariantTestUtil.testVariant(value, v -> {
+ VariantTestUtil.checkType(v, VariantUtil.PRIMITIVE, Variant.Type.LONG);
Assert.assertEquals(-1L, v.getLong());
});
}
@Test
public void testInt() {
Variant value = new Variant(
- ByteBuffer.wrap(new byte[] {primitiveHeader(5), (byte) 0xD2, 0x02,
(byte) 0x96, 0x49}), EMPTY_METADATA);
- testVariant(value, v -> {
- checkType(v, VariantUtil.PRIMITIVE, Variant.Type.INT);
+ ByteBuffer.wrap(new byte[] {VariantTestUtil.primitiveHeader(5), (byte)
0xD2, 0x02, (byte) 0x96, 0x49}),
+ VariantTestUtil.EMPTY_METADATA);
+ VariantTestUtil.testVariant(value, v -> {
+ VariantTestUtil.checkType(v, VariantUtil.PRIMITIVE, Variant.Type.INT);
Assert.assertEquals(1234567890, v.getInt());
});
}
@Test
public void testNegativeInt() {
Variant value = new Variant(
- ByteBuffer.wrap(new byte[] {primitiveHeader(5), (byte) 0xFF, (byte)
0xFF, (byte) 0xFF, (byte) 0xFF}),
- EMPTY_METADATA);
- testVariant(value, v -> {
- checkType(v, VariantUtil.PRIMITIVE, Variant.Type.INT);
+ ByteBuffer.wrap(new byte[] {
+ VariantTestUtil.primitiveHeader(5), (byte) 0xFF, (byte) 0xFF, (byte)
0xFF, (byte) 0xFF
+ }),
+ VariantTestUtil.EMPTY_METADATA);
+ VariantTestUtil.testVariant(value, v -> {
+ VariantTestUtil.checkType(v, VariantUtil.PRIMITIVE, Variant.Type.INT);
Assert.assertEquals(-1, v.getInt());
});
}
@Test
public void testShort() {
- Variant value =
- new Variant(ByteBuffer.wrap(new byte[] {primitiveHeader(4), (byte)
0xD2, 0x04}), EMPTY_METADATA);
- testVariant(value, v -> {
- checkType(v, VariantUtil.PRIMITIVE, Variant.Type.SHORT);
+ Variant value = new Variant(
+ ByteBuffer.wrap(new byte[] {VariantTestUtil.primitiveHeader(4), (byte)
0xD2, 0x04}),
+ VariantTestUtil.EMPTY_METADATA);
+ VariantTestUtil.testVariant(value, v -> {
+ VariantTestUtil.checkType(v, VariantUtil.PRIMITIVE, Variant.Type.SHORT);
Assert.assertEquals((short) 1234, v.getShort());
});
}
@Test
public void testNegativeShort() {
- Variant value =
- new Variant(ByteBuffer.wrap(new byte[] {primitiveHeader(4), (byte)
0xFF, (byte) 0xFF}), EMPTY_METADATA);
- testVariant(value, v -> {
- checkType(v, VariantUtil.PRIMITIVE, Variant.Type.SHORT);
+ Variant value = new Variant(
+ ByteBuffer.wrap(new byte[] {VariantTestUtil.primitiveHeader(4), (byte)
0xFF, (byte) 0xFF}),
+ VariantTestUtil.EMPTY_METADATA);
+ VariantTestUtil.testVariant(value, v -> {
+ VariantTestUtil.checkType(v, VariantUtil.PRIMITIVE, Variant.Type.SHORT);
Assert.assertEquals((short) -1, v.getShort());
});
}
@Test
public void testByte() {
- Variant value = new Variant(ByteBuffer.wrap(new byte[]
{primitiveHeader(3), 34}), EMPTY_METADATA);
- testVariant(value, v -> {
- checkType(v, VariantUtil.PRIMITIVE, Variant.Type.BYTE);
+ Variant value = new Variant(
+ ByteBuffer.wrap(new byte[] {VariantTestUtil.primitiveHeader(3), 34}),
VariantTestUtil.EMPTY_METADATA);
+ VariantTestUtil.testVariant(value, v -> {
+ VariantTestUtil.checkType(v, VariantUtil.PRIMITIVE, Variant.Type.BYTE);
Assert.assertEquals((byte) 34, v.getByte());
});
}
@Test
public void testNegativeByte() {
- Variant value = new Variant(ByteBuffer.wrap(new byte[]
{primitiveHeader(3), (byte) 0xFF}), EMPTY_METADATA);
- testVariant(value, v -> {
- checkType(v, VariantUtil.PRIMITIVE, Variant.Type.BYTE);
+ Variant value = new Variant(
+ ByteBuffer.wrap(new byte[] {VariantTestUtil.primitiveHeader(3), (byte)
0xFF}),
+ VariantTestUtil.EMPTY_METADATA);
+ VariantTestUtil.testVariant(value, v -> {
+ VariantTestUtil.checkType(v, VariantUtil.PRIMITIVE, Variant.Type.BYTE);
Assert.assertEquals((byte) -1, v.getByte());
});
}
+ @Test
+ public void testLongBuilder() {
+ Arrays.asList(
+ 0L,
+ (long) Byte.MIN_VALUE,
+ (long) Byte.MAX_VALUE,
+ (long) Short.MIN_VALUE,
+ (long) Short.MAX_VALUE,
+ (long) Integer.MIN_VALUE,
+ (long) Integer.MAX_VALUE,
+ Long.MIN_VALUE,
+ Long.MAX_VALUE)
+ .forEach(l -> {
+ VariantBuilder vb2 = new VariantBuilder(false);
+ vb2.appendLong(l);
+ VariantTestUtil.testVariant(vb2.build(), v -> {
+ VariantTestUtil.checkType(v, VariantUtil.PRIMITIVE,
Variant.Type.LONG);
+ Assert.assertEquals((long) l, v.getLong());
+ });
+ });
+ }
+
+ @Test
+ public void testIntBuilder() {
+ Arrays.asList(
+ 0,
+ (int) Byte.MIN_VALUE,
+ (int) Byte.MAX_VALUE,
+ (int) Short.MIN_VALUE,
+ (int) Short.MAX_VALUE,
+ Integer.MIN_VALUE,
+ Integer.MAX_VALUE)
+ .forEach(i -> {
+ VariantBuilder vb2 = new VariantBuilder(false);
+ vb2.appendInt(i);
+ VariantTestUtil.testVariant(vb2.build(), v -> {
+ VariantTestUtil.checkType(v, VariantUtil.PRIMITIVE,
Variant.Type.INT);
+ Assert.assertEquals((int) i, v.getInt());
+ });
+ });
+ }
+
+ @Test
+ public void testShortBuilder() {
+ Arrays.asList((short) 0, (short) Byte.MIN_VALUE, (short) Byte.MAX_VALUE,
Short.MIN_VALUE, Short.MAX_VALUE)
+ .forEach(s -> {
+ VariantBuilder vb2 = new VariantBuilder(false);
+ vb2.appendShort(s);
+ VariantTestUtil.testVariant(vb2.build(), v -> {
+ VariantTestUtil.checkType(v, VariantUtil.PRIMITIVE,
Variant.Type.SHORT);
+ Assert.assertEquals((short) s, v.getShort());
+ });
+ });
+ }
+
+ @Test
+ public void testByteBuilder() {
Review Comment:
Good testing here!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
