rdblue commented on code in PR #3202:
URL: https://github.com/apache/parquet-java/pull/3202#discussion_r2069546755
##########
parquet-variant/src/test/java/org/apache/parquet/variant/TestVariantScalar.java:
##########
@@ -415,23 +574,43 @@ public void testNegativeTimestamp() {
(byte) 0xFF,
(byte) 0xFF
}),
- EMPTY_METADATA);
- testVariant(value, v -> {
- checkType(v, VariantUtil.PRIMITIVE, Variant.Type.TIMESTAMP_TZ);
+ VariantTestUtil.EMPTY_METADATA);
+ VariantTestUtil.testVariant(value, v -> {
+ VariantTestUtil.checkType(v, VariantUtil.PRIMITIVE,
Variant.Type.TIMESTAMP_TZ);
Assert.assertEquals(
Instant.parse("1969-12-31T23:59:59.999999Z"),
Instant.EPOCH.plus(v.getLong(), ChronoUnit.MICROS));
});
}
+ @Test
+ public void testTimestampTzBuilder() {
+ DateTimeFormatter dtf = DateTimeFormatter.ISO_DATE_TIME;
+ VariantBuilder vb = new VariantBuilder(false);
+ long micros =
VariantTestUtil.microsSinceEpoch(Instant.from(dtf.parse("2024-12-16T10:23:45.321456-08:00")));
Review Comment:
It doesn't look like converting the parsed date brings much value so I'd
probably remove the conversion. It isn't worth the maintenance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
