hemantk-12 commented on code in PR #8157:
URL: https://github.com/apache/ozone/pull/8157#discussion_r2054783740
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshotManager.java:
##########
@@ -849,6 +858,40 @@ private void validateSnapshotsExistAndActive(final String
volumeName,
checkSnapshotActive(toSnapInfo, false);
}
+ public void snapshotLimitCheck() throws IOException, OMException {
+ OmMetadataManagerImpl omMetadataManager = (OmMetadataManagerImpl)
ozoneManager.getMetadataManager();
+ SnapshotChainManager snapshotChainManager =
omMetadataManager.getSnapshotChainManager();
+ int currentSnapshotNum =
snapshotChainManager.getGlobalSnapshotChain().size();
+ int oldCount = inFlightSnapshotCount.get();
+ int newCount = inFlightSnapshotCount.updateAndGet(count -> {
Review Comment:
Since we are using two steps, get and update, we may throw an exception for
a few snapshot requests due to the case condition between get and update. It is
not a big deal, but we can avoid it by putting it inside a synchronized block
on `inFlightSnapshotCount` object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
