hemantk-12 commented on code in PR #8157:
URL: https://github.com/apache/ozone/pull/8157#discussion_r2039921272


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshotManager.java:
##########
@@ -849,6 +856,25 @@ private void validateSnapshotsExistAndActive(final String 
volumeName,
     checkSnapshotActive(toSnapInfo, false);
   }
 
+  public void validateSnapshotLimit() throws IOException {

Review Comment:
   @swamirishi and I were discussing this, and one way to fix it is to 
implement `notifyLeaderReady()` and `notifyNotLeader()` similar to 
[SCMStateMachine](https://github.com/apache/ozone/blob/7dfd8c1a7889b5947c87f81d1c4d24a30bf629f6/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMStateMachine.java#L372)
 for OzoneManager and reset the `inflight` counter on leadership change.
   
   cc: @swamirishi @SaketaChalamchala 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to