swamirishi commented on code in PR #8157:
URL: https://github.com/apache/ozone/pull/8157#discussion_r2059642586
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshotManager.java:
##########
@@ -849,6 +858,40 @@ private void validateSnapshotsExistAndActive(final String
volumeName,
checkSnapshotActive(toSnapInfo, false);
}
+ public void snapshotLimitCheck() throws IOException, OMException {
+ OmMetadataManagerImpl omMetadataManager = (OmMetadataManagerImpl)
ozoneManager.getMetadataManager();
+ SnapshotChainManager snapshotChainManager =
omMetadataManager.getSnapshotChainManager();
+ int currentSnapshotNum =
snapshotChainManager.getGlobalSnapshotChain().size();
+ int oldCount = inFlightSnapshotCount.get();
+ int newCount = inFlightSnapshotCount.updateAndGet(count -> {
Review Comment:
@peterxcli Why can't we directly have an AtomicReference<OMException>
outside the block? This can be just set to the exception that needs to be
thrown if at all it needs to be thrown
with a null check it can be checked outside of the getAndUpdate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
