swamirishi commented on PR #8157: URL: https://github.com/apache/ozone/pull/8157#issuecomment-2798223689
@peterxcli Had a discussion with @hemantk-12 we should go ahead with enforcing hard limits on the number of snapshots. For that the number of snapshot creates inflight would have to be considered. This counter should be only relevant on leader. So on every leader switch this counter needs to be reset, which can be detected by implementing NotifyLeaderChanged https://github.com/apache/ratis/blob/c81902a094344d953f2fc5f5d7ed08dc7c171cdf/ratis-server-api/src/main/java/org/apache/ratis/statemachine/StateMachine.java#L215-L218 for ozoneManagerStateMachine https://github.com/apache/ozone/blob/dc9952e446940b82b277a7e8c9d02239a8417a06/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerStateMachine.java#L92 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
