swamirishi commented on code in PR #8157:
URL: https://github.com/apache/ozone/pull/8157#discussion_r2036075294
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshotManager.java:
##########
@@ -856,23 +858,31 @@ private void validateSnapshotsExistAndActive(final String
volumeName,
checkSnapshotActive(toSnapInfo, false);
}
- public void validateSnapshotLimit() throws IOException {
+ /*
+ * Check snapshot limit
+ * Note: This method increments the snapshot in-flight counter
+ */
+ public synchronized void snapshotLimitCheck() throws IOException {
OmMetadataManagerImpl omMetadataManager = (OmMetadataManagerImpl)
ozoneManager.getMetadataManager();
SnapshotChainManager snapshotChainManager =
omMetadataManager.getSnapshotChainManager();
int currentSnapshotNum =
snapshotChainManager.getGlobalSnapshotChain().size();
- if (currentSnapshotNum >= fsSnapshotMaxLimit) {
+ int inFlightCount = inFlightSnapshotCount.get();
Review Comment:
@peterxcli We should do this entire validation inside inFlightCount.update()
block
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
