[
https://issues.apache.org/jira/browse/MINIFICPP-365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329586#comment-16329586
]
ASF GitHub Bot commented on MINIFICPP-365:
------------------------------------------
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/244#discussion_r162196014
--- Diff: libminifi/src/core/ProcessSession.cpp ---
@@ -568,16 +568,16 @@ void ProcessSession::import(std::string source,
std::vector<std::shared_ptr<Flow
}
bool ProcessSession::exportContent(const std::string &destination, const
std::string &tmpFile, const std::shared_ptr<core::FlowFile> &flow, bool
keepContent) {
- logger_->log_info("Exporting content of %s to %s",
flow->getUUIDStr().c_str(), destination.c_str());
+ logger_->log_debug("Exporting content of %s to %s",
flow->getUUIDStr().c_str(), destination.c_str());
ProcessSessionReadCallback cb(tmpFile, destination, logger_);
read(flow, &cb);
- logger_->log_info("Committing %s", destination.c_str());
+ logger_->log_debug("Committing %s", destination.c_str());
bool commit_ok = cb.commit();
if (commit_ok) {
- logger_->log_info("Commit OK.");
+ logger_->log_debug("Commit OK.");
--- End diff --
I'm on the fence about this one. I usually use the mantra as INFO provides
informational statements for support staff, debug and trace used by developers
for varying levels. In this case I could see a support staff asking, "Commit
OK." Is there an analog to this statement to provide this information? A
totally quiet client at info makes it unusable and more importantly
unsupportable by multiple levels of support.
> Refine log levels and messages
> ------------------------------
>
> Key: MINIFICPP-365
> URL: https://issues.apache.org/jira/browse/MINIFICPP-365
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Aldrin Piri
> Assignee: Aldrin Piri
> Priority: Major
> Fix For: 0.4.0
>
>
> minifi-app.log is verbose and includes a lot of information at an INFO level
> that is below the typical information a person might care to see. Some
> statements are likely extraneous and remnants of development, some should be
> dropped to a lower priority and others seem duplicative.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
