[
https://issues.apache.org/jira/browse/MINIFICPP-365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329564#comment-16329564
]
ASF GitHub Bot commented on MINIFICPP-365:
------------------------------------------
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/244#discussion_r162194109
--- Diff: libminifi/src/sitetosite/SiteToSiteClient.cpp ---
@@ -467,12 +467,12 @@ int16_t SiteToSiteClient::send(std::string
transactionID, DataPacket *packet, co
}
if (transaction->getState() != TRANSACTION_STARTED &&
transaction->getState() != DATA_EXCHANGED) {
- logger_->log_debug("Site2Site transaction %s is not at started or
exchanged state", transactionID.c_str());
--- End diff --
we should also make it a point to change these from transactionID.c_str()
to tranactionID
> Refine log levels and messages
> ------------------------------
>
> Key: MINIFICPP-365
> URL: https://issues.apache.org/jira/browse/MINIFICPP-365
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Aldrin Piri
> Assignee: Aldrin Piri
> Priority: Major
> Fix For: 0.4.0
>
>
> minifi-app.log is verbose and includes a lot of information at an INFO level
> that is below the typical information a person might care to see. Some
> statements are likely extraneous and remnants of development, some should be
> dropped to a lower priority and others seem duplicative.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
