[
https://issues.apache.org/jira/browse/MINIFICPP-365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329582#comment-16329582
]
ASF GitHub Bot commented on MINIFICPP-365:
------------------------------------------
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/244#discussion_r162195460
--- Diff: libminifi/src/core/ProcessSessionReadCallback.cpp ---
@@ -64,16 +64,16 @@ int64_t
ProcessSessionReadCallback::process(std::shared_ptr<io::BaseStream> stre
bool ProcessSessionReadCallback::commit() {
bool success = false;
- logger_->log_info("committing export operation to %s",
_destFile.c_str());
--- End diff --
ditto on the c_str(). It adds overhead and is vestigial.
> Refine log levels and messages
> ------------------------------
>
> Key: MINIFICPP-365
> URL: https://issues.apache.org/jira/browse/MINIFICPP-365
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Aldrin Piri
> Assignee: Aldrin Piri
> Priority: Major
> Fix For: 0.4.0
>
>
> minifi-app.log is verbose and includes a lot of information at an INFO level
> that is below the typical information a person might care to see. Some
> statements are likely extraneous and remnants of development, some should be
> dropped to a lower priority and others seem duplicative.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
