[
https://issues.apache.org/jira/browse/MINIFICPP-365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329579#comment-16329579
]
ASF GitHub Bot commented on MINIFICPP-365:
------------------------------------------
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/244#discussion_r162195004
--- Diff: libminifi/src/sitetosite/RawSocketProtocol.cpp ---
@@ -112,11 +112,11 @@ bool
RawSiteToSiteClient::initiateResourceNegotiation() {
return false;
}
- logger_->log_info("Negotiate protocol version with destination port %s
current version %d", port_id_str_, _currentVersion);
+ logger_->log_debug("Negotiate protocol version with destination port %s
current version %d", port_id_str_, _currentVersion);
int ret = peer_->writeUTF(getResourceName());
- logger_->log_info("result of writing resource name is %i", ret);
+ logger_->log_debug("result of writing resource name is %i", ret);
--- End diff --
^ this honestly seems like it would be a trace level to help trace the
level of execution through the stream writes.
> Refine log levels and messages
> ------------------------------
>
> Key: MINIFICPP-365
> URL: https://issues.apache.org/jira/browse/MINIFICPP-365
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Aldrin Piri
> Assignee: Aldrin Piri
> Priority: Major
> Fix For: 0.4.0
>
>
> minifi-app.log is verbose and includes a lot of information at an INFO level
> that is below the typical information a person might care to see. Some
> statements are likely extraneous and remnants of development, some should be
> dropped to a lower priority and others seem duplicative.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
