lordgamez commented on code in PR #1945:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1945#discussion_r2048613793
##########
cmake/FetchBenchmark.cmake:
##########
Review Comment:
When I run the configuration with the performance tests enabled locally it
fails with the following error:
```
CMake Error at CMakeLists.txt:34 (message):
Did not find Google Test sources! Either pass correct path in
GOOGLETEST_PATH, or enable BENCHMARK_DOWNLOAD_DEPENDENCIES, or disable
BENCHMARK_USE_BUNDLED_GTEST, or disable BENCHMARK_ENABLE_GTEST_TESTS /
BENCHMARK_ENABLE_TESTING.
-- Configuring incomplete, errors occurred!
CMake Error at build/_deps/benchmark-src/cmake/GoogleTest.cmake:13 (message):
CMake step for googletest failed: 1
Call Stack (most recent call first):
build/_deps/benchmark-src/CMakeLists.txt:345 (include)
-- Configuring incomplete, errors occurred!
```
I suppose this is caused if the googletest target is created after the
benchmark is configured. This can be fixed by adding the following, and this
should be okay as we do not need to build the tests of the benchmark library
anyway:
```
set(BENCHMARK_ENABLE_TESTING "OFF" CACHE STRING "" FORCE)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
