martinzink commented on code in PR #1945: URL: https://github.com/apache/nifi-minifi-cpp/pull/1945#discussion_r2007509808
########## cmake/FindBenchmark.cmake: ########## @@ -0,0 +1,26 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# +include(FetchContent) + +FetchContent_Declare( + benchmark + URL https://github.com/google/benchmark/archive/refs/tags/v1.9.1.tar.gz + URL_HASH SHA256=32131c08ee31eeff2c8968d7e874f3cb648034377dfc32a4c377fa8796d84981 Review Comment: The cmake failures probably can be fixed with ```suggestion URL_HASH SHA256=32131c08ee31eeff2c8968d7e874f3cb648034377dfc32a4c377fa8796d84981 OVERRIDE_FIND_PACKAGE ``` I would also rename this to FetchBenchmark.cmake and include(FetchBenchmark) in the performance/CMakeLists.txt ########## libminifi/include/core/repository/VolatileContentRepository.h: ########## @@ -17,113 +17,35 @@ #pragma once -#include <map> -#include <memory> -#include <string> -#include <string_view> - -#include "AtomicRepoEntries.h" -#include "io/AtomicEntryStream.h" #include "core/ContentRepository.h" Review Comment: ```suggestion ``` ########## libminifi/include/core/repository/VolatileContentRepository.h: ########## @@ -17,113 +17,35 @@ #pragma once -#include <map> -#include <memory> -#include <string> -#include <string_view> - -#include "AtomicRepoEntries.h" -#include "io/AtomicEntryStream.h" #include "core/ContentRepository.h" -#include "properties/Configure.h" -#include "core/Connectable.h" -#include "core/logging/LoggerFactory.h" -#include "utils/GeneralUtils.h" -#include "VolatileRepositoryData.h" -#include "utils/Literals.h" +#include <map> Review Comment: This caused the linter error ```suggestion #include <unordered_map> #include <string> #include <memory> #include <mutex> #include "core/ContentRepository.h" ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
