lordgamez commented on code in PR #1945: URL: https://github.com/apache/nifi-minifi-cpp/pull/1945#discussion_r2048607714
########## cmake/MiNiFiOptions.cmake: ########## @@ -44,6 +44,7 @@ endfunction() add_minifi_option(CI_BUILD "Build is used for CI." OFF) add_minifi_option(SKIP_TESTS "Skips building all tests." OFF) +add_minifi_option(MINIFI_PERFORMANCE_TESTS "Build performance tests" OFF) Review Comment: I think we can keep them optional as they are better to be on-demand when we want to measure any performance. Even if it would take no time to run the average user would not have any benefit from running them together with the other tests as they cannot really fail, but later when additional performance tests are added it might take a long time to run them. Although on my machine it took a lot of time when running them together with the other tests: ``` 200/204 Test #185: HTTPSiteToSiteTests ........................ Passed 10.63 sec 201/204 Test #3: ListenHTTPTests ............................ Passed 11.73 sec 202/204 Test #200: PersistenceTests ........................... Passed 16.62 sec 203/204 Test #70: VerifyInvokeHTTPPostTest ................... Passed 18.22 sec 204/204 Test #156: VolatileRepositoryPerfTests ................ Passed 95.64 sec ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
