szaszm commented on code in PR #1945: URL: https://github.com/apache/nifi-minifi-cpp/pull/1945#discussion_r2042247596
########## .github/workflows/ci.yml: ########## Review Comment: I think we should run the perf tests separately with `--verbose`, so we can see the numbers in the build log. They can go before or after the normal unit tests. Since they take about no time, we don't even need to disable them in the normal test run, just also run them separately with output enabled. ########## cmake/MiNiFiOptions.cmake: ########## @@ -44,6 +44,7 @@ endfunction() add_minifi_option(CI_BUILD "Build is used for CI." OFF) add_minifi_option(SKIP_TESTS "Skips building all tests." OFF) +add_minifi_option(MINIFI_PERFORMANCE_TESTS "Build performance tests" OFF) Review Comment: I think we can remove the option and always enable them, since they seem to take approximately no time to run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
