twalthr commented on code in PR #29339:
URL: https://github.com/apache/flink/pull/29339#discussion_r4164605412
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/common/JoinTestPrograms.java:
##########
@@ -501,5 +506,112 @@ public class JoinTestPrograms {
+ " WHEN a NOT IN (SELECT CAST(j AS
INTEGER) FROM source_t3) THEN 2 ELSE 3 END)"
+ " NOT IN (SELECT d FROM source_t2
WHERE source_t1.c = source_t2.f)")
.build();
+
+ LEFT_JOIN_WITH_UPSERT_INPUT_AND_NON_EQUI_CONDITION =
Review Comment:
```suggestion
LEFT_JOIN_UPSERT_INPUT_NON_EQUI =
```
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/common/JoinTestPrograms.java:
##########
@@ -501,5 +506,112 @@ public class JoinTestPrograms {
+ " WHEN a NOT IN (SELECT CAST(j AS
INTEGER) FROM source_t3) THEN 2 ELSE 3 END)"
+ " NOT IN (SELECT d FROM source_t2
WHERE source_t1.c = source_t2.f)")
.build();
+
+ LEFT_JOIN_WITH_UPSERT_INPUT_AND_NON_EQUI_CONDITION =
+ leftJoinWithUpsertInputAndNonEquiCondition(
+
"join-left-join-with-upsert-input-and-non-equi-condition",
Review Comment:
```suggestion
"join-left-join-upsert-input-non-equi",
```
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/common/JoinTestPrograms.java:
##########
@@ -501,5 +506,112 @@ public class JoinTestPrograms {
+ " WHEN a NOT IN (SELECT CAST(j AS
INTEGER) FROM source_t3) THEN 2 ELSE 3 END)"
+ " NOT IN (SELECT d FROM source_t2
WHERE source_t1.c = source_t2.f)")
.build();
+
+ LEFT_JOIN_WITH_UPSERT_INPUT_AND_NON_EQUI_CONDITION =
+ leftJoinWithUpsertInputAndNonEquiCondition(
+
"join-left-join-with-upsert-input-and-non-equi-condition",
+ "left join with an upsert input and a non-equi
condition");
+
+ // leftInputChangelogMode and rightInputChangelogMode are removed from
its stored plan,
+ // which
+ // makes it a plan of a previous version
+ LEFT_JOIN_WITH_UPSERT_INPUT_AND_NON_EQUI_CONDITION_PREVIOUS_PLAN =
+ leftJoinWithUpsertInputAndNonEquiCondition(
+
"join-left-join-with-upsert-input-and-non-equi-condition-previous-plan",
+ "left join with an upsert input and a non-equi
condition restored from a plan of a previous version");
+
+ // the full image of the deleted line is only in the restored state
+ INNER_JOIN_WITH_KEY_ONLY_DELETES_AND_NON_EQUI_CONDITION =
Review Comment:
```suggestion
INNER_JOIN_KEY_ONLY_DELETES_NON_EQUI =
```
##########
flink-table/flink-table-planner/src/test/resources/restore-tests/stream-exec-join_1/join-left-join-with-upsert-input-and-non-equi-condition-previous-plan/plan/join-left-join-with-upsert-input-and-non-equi-condition-previous-plan.json:
##########
@@ -0,0 +1,252 @@
+{
+ "flinkVersion" : "2.4",
Review Comment:
compile a 2.3 plan
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/join/stream/StreamingJoinOperator.java:
##########
@@ -43,6 +47,20 @@ public class StreamingJoinOperator extends
AbstractStreamingJoinOperator {
protected final boolean leftIsOuter;
// whether right side is outer side, e.g. right is outer but left is not
when RIGHT OUTER JOIN
protected final boolean rightIsOuter;
+ // changelog mode of the left input, null for compiled plans of previous
versions
Review Comment:
concrete Flink version number here
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/common/JoinTestPrograms.java:
##########
@@ -501,5 +506,112 @@ public class JoinTestPrograms {
+ " WHEN a NOT IN (SELECT CAST(j AS
INTEGER) FROM source_t3) THEN 2 ELSE 3 END)"
+ " NOT IN (SELECT d FROM source_t2
WHERE source_t1.c = source_t2.f)")
.build();
+
+ LEFT_JOIN_WITH_UPSERT_INPUT_AND_NON_EQUI_CONDITION =
+ leftJoinWithUpsertInputAndNonEquiCondition(
+
"join-left-join-with-upsert-input-and-non-equi-condition",
+ "left join with an upsert input and a non-equi
condition");
+
+ // leftInputChangelogMode and rightInputChangelogMode are removed from
its stored plan,
+ // which
+ // makes it a plan of a previous version
+ LEFT_JOIN_WITH_UPSERT_INPUT_AND_NON_EQUI_CONDITION_PREVIOUS_PLAN =
Review Comment:
```suggestion
LEFT_JOIN_UPSERT_INPUT_NON_EQUI_PRE_2_4 =
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
