gustavodemorais commented on code in PR #29339:
URL: https://github.com/apache/flink/pull/29339#discussion_r4156602577
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecJoin.java:
##########
@@ -287,4 +319,12 @@ protected Transformation<RowData> translateToPlanInternal(
transform.setStateKeyType(leftSelect.getProducedType());
return transform;
}
+
+ /** Compiled plans of previous versions do not contain the changelog modes
of the inputs. */
+ private static @Nullable RuntimeChangelogMode toRuntimeChangelogMode(
Review Comment:
> Just to double check: leftUpsertKeys is also set in retract?
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
