twalthr commented on code in PR #29339:
URL: https://github.com/apache/flink/pull/29339#discussion_r4144792962
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/join/stream/StreamingJoinOperator.java:
##########
@@ -43,6 +45,8 @@ public class StreamingJoinOperator extends
AbstractStreamingJoinOperator {
protected final boolean leftIsOuter;
// whether right side is outer side, e.g. right is outer but left is not
when RIGHT OUTER JOIN
protected final boolean rightIsOuter;
+ // whether the join condition has a non-equi part, e.g. l.v > r.v
Review Comment:
add a better example:
```
A JOIN B ON A.k = B.k AND A.v > B.v
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
