gustavodemorais commented on PR #29339: URL: https://github.com/apache/flink/pull/29339#issuecomment-5915426089
Hey Timo, thanks for looking into the PR and the review 1. Tests on leftHasUniqueKeySpec: The planner drops UPDATE_BEFORE when the upsert key contains the join key (StreamPhysicalJoin#inputUniqueKeyContainsJoinKey), so this spec does actually get bare upserts. A join input only receives upsert if input's upsert key contains the join key (StreamPhysicalJoin#inputUniqueKeyContainsJoinKey). That covers two specs: the unique key equals the join key (JoinKeyContainsUniqueKey), or it has additional columns (HasUniqueKey), e.g. PK (order_id, line_id) joined on order_id. In both cases a replacement keeps its join key, so the tests model a real shape. Added a comment on the spec 2. Pseudocode drift Synced 3. Delete-by-key + non-equi Confirmed. It's indeed an issue for this case. I've created the ticket https://issues.apache.org/jira/browse/FLINK-40858 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
