snuyanzin commented on code in PR #25763: URL: https://github.com/apache/flink/pull/25763#discussion_r1889027572
########## flink-table/flink-table-common/src/main/java/org/apache/flink/table/utils/DateTimeUtils.java: ########## @@ -365,6 +368,38 @@ public static TimestampData toTimestampData(double v, int precision) { } } + public static TimestampData toTimestampData(int v, int precision) { + switch (precision) { + case 0: + if (MIN_EPOCH_SECONDS <= v && v <= MAX_EPOCH_SECONDS) { + return timestampDataFromEpochMills((v * MILLIS_PER_SECOND)); + } else { + return null; + } + case 3: + return timestampDataFromEpochMills(v); + default: + throw new TableException( + "The precision value '" + + precision + + "' for function " + + "TO_TIMESTAMP_LTZ(numeric, precision) is unsupported," + + " the supported value is '0' for second or '3' for millisecond."); + } + } + + public static TimestampData toTimestampData(long epoch) { + return toTimestampData(epoch, DEFAULT_PRECISION); + } + + public static TimestampData toTimestampData(double epoch) { + return toTimestampData(epoch, DEFAULT_PRECISION); + } + + public static TimestampData toTimestampData(DecimalData epoch) { + return toTimestampData(epoch, DEFAULT_PRECISION); + } Review Comment: Move this to function class -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org