yiyutian1 commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1886093369
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/utils/DateTimeUtils.java:
##########
@@ -385,6 +388,18 @@ public static TimestampData toTimestampData(int v, int
precision) {
}
}
Review Comment:
To address this comment, I replaced 3 with a constant.
After giving it some thought, I believe it's better to keep these functions
in DateTimeUtils.java rather than moving them to toTimestampLtzFunction, since
toTimestampLtzFunction already depends on DateTimeUtils.java as a library. What
are your thoughts on this? @snuyanzin
> from any user outside of TO_TIMESTAMP_LTZ 3 here is a magic number.
> I would suggest to have such calls only in your toTimestampLtzFunction
class and don't put them here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
