yiyutian1 commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1886090826
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ToTimestampLtzFunction.java:
##########
@@ -92,74 +121,72 @@ public TimestampData eval(Integer epoch) {
return null;
}
- return eval(epoch, 3);
Review Comment:
Replying to this comment:
This is not possible, because we handle exact numeric and fractional data
differently. Therefore, we can’t use the umbrella Number for them.
I keep them as is to be consistent with existing logic.
@snuyanzin , if you have a better way, please shed some lights here.
> Can not we replace a number of these duplicating methods with something
like
>
> public TimestampData eval(Number epoch) {
> if (epoch == null) {
> return null;
> }
>
> return eval(epoch, 3);
> }
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
