snuyanzin commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1888999720


##########
docs/data/sql_functions.yml:
##########
@@ -679,9 +679,15 @@ temporal:
   - sql: TO_DATE(string1[, string2])
     table: toDate(STRING1[, STRING2])
     description: Converts a date string string1 with format string2 (by 
default 'yyyy-MM-dd') to a date.
-  - sql: TO_TIMESTAMP_LTZ(numeric, precision)
+  - sql: TO_TIMESTAMP_LTZ(numeric[, precision])
     table: toTimestampLtz(NUMERIC, PRECISION)
-    description: "Converts a epoch seconds or epoch milliseconds to a 
TIMESTAMP_LTZ, the valid precision is 0 or 3, the 0 represents 
TO_TIMESTAMP_LTZ(epochSeconds, 0), the 3 represents 
TO_TIMESTAMP_LTZ(epochMilliseconds, 3)."
+    description: Converts an epoch seconds or epoch milliseconds to a 
TIMESTAMP_LTZ, the valid precision is 0 or 3, the 0 represents 
TO_TIMESTAMP_LTZ(epochSeconds, 0), the 3 represents 
TO_TIMESTAMP_LTZ(epochMilliseconds, 3). If no precision is provided, the 
default precision is 3.
+  - sql: TO_TIMESTAMP_LTZ(string1[, string2])
+    table: toTimestampLtz(STRING1[, STRING2])
+    description: Converts a timestamp string string1 with format string2 (by 
default 'yyyy-MM-dd HH:mm:ss.SSS') to a TIMESTAMP_LTZ.
+  - sql: TO_TIMESTAMP_LTZ(string1, string2, string3)
+    table: toTimestampLtz(STRING1, STRING2, STRING3)
+    description: Converts a timestamp string string1 with format string2 to a 
TIMESTAMP_LTZ in time zone string3.

Review Comment:
   can we merge into one like
   ```yml
   - sql: TO_TIMESTAMP_LTZ(string1[, string2[, string3]])
     table: toTimestampLtz(STRING1[, STRING2[, STRING3]])
   ```
   ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to