huyuanfeng2018 commented on code in PR #921:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/921#discussion_r1881498295
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricEvaluator.java:
##########
@@ -296,8 +297,16 @@ protected static void computeProcessingRateThresholds(
upperUtilization = 1.0;
lowerUtilization = 0.0;
} else {
- upperUtilization = targetUtilization + utilizationBoundary;
- lowerUtilization = targetUtilization - utilizationBoundary;
+ if (conf.getOptional(UTILIZATION_MAX).isPresent()
+ || conf.getOptional(UTILIZATION_MIN).isPresent()
+ ||
conf.getOptional(TARGET_UTILIZATION_BOUNDARY).isEmpty()) {
+ upperUtilization = conf.get(UTILIZATION_MAX);
+ lowerUtilization = conf.get(UTILIZATION_MIN);
Review Comment:
I don't know if there is something wrong with my understanding:
Should we keep the boundary and then the max and min values are derived
by `boundary + target` and `target - boundary` by default? Unless the user
explicitly sets min max?
If that's the case, I think it's reasonable.
But in this case, should we change the min max parameter like to
`utilization.lower.boundary` and `utilization.upper.boundary` ?
Then `max = upper.boundary+ target` , `min = target- upper.boundary`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
