gyfora commented on code in PR #921:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/921#discussion_r1884213489
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricEvaluator.java:
##########
@@ -296,8 +297,16 @@ protected static void computeProcessingRateThresholds(
upperUtilization = 1.0;
lowerUtilization = 0.0;
} else {
- upperUtilization = targetUtilization + utilizationBoundary;
- lowerUtilization = targetUtilization - utilizationBoundary;
+ if (conf.getOptional(UTILIZATION_MAX).isPresent()
+ || conf.getOptional(UTILIZATION_MIN).isPresent()
+ ||
conf.getOptional(TARGET_UTILIZATION_BOUNDARY).isEmpty()) {
+ upperUtilization = conf.get(UTILIZATION_MAX);
+ lowerUtilization = conf.get(UTILIZATION_MIN);
Review Comment:
As @mxm suggested I think the logic should be enabled if either MIN or MAX
is defined. If only one of them is defined then we can compute the default for
the other one from the target utilization +- boundary.
I think we should not have default values for the min/max options
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
