yuxiqian commented on code in PR #3658:
URL: https://github.com/apache/flink-cdc/pull/3658#discussion_r1836571642
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/com/github/shyiko/mysql/binlog/event/deserialization/json/JsonStringFormatter.java:
##########
Review Comment:
Can we make this enhancement an optional configuration and defaults to the
legacy format, considering some users may have relied on this specific JSON
format?
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/test/java/org/apache/flink/cdc/connectors/mysql/source/MySqlFullTypesITCase.java:
##########
@@ -412,7 +412,7 @@ private void testCommonDataTypes(UniqueDatabase database)
throws Exception {
expectedSnapshot[30] = null;
// The json string from binlog will remove useless space
- expectedSnapshot[44] =
BinaryStringData.fromString("{\"key1\":\"value1\"}");
+ expectedSnapshot[44] = BinaryStringData.fromString("{\"key1\":
\"value1\"}");
Review Comment:
This additional assignment was meant to fix the format discrepancy and could
be removed now.
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/test/java/org/apache/flink/cdc/connectors/mysql/source/MySqlFullTypesITCase.java:
##########
Review Comment:
Can we add some tests to verify if we have the same JSON format between
snapshot and binlog stage?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
