SML0127 commented on code in PR #3658: URL: https://github.com/apache/flink-cdc/pull/3658#discussion_r1845342619
########## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/test/java/org/apache/flink/cdc/connectors/mysql/source/MySqlFullTypesITCase.java: ########## Review Comment: I added tests for this new option. When `useLegacyJsonFormat = flase`, it verifies that the JSON type data format is the same between snapshot stage and binlog stage. https://github.com/apache/flink-cdc/blob/337b5de64f58041fff6383f76c103af54b7eec11/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/test/java/org/apache/flink/cdc/connectors/mysql/source/MySqlFullTypesITCase.java#L498-L551 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
