SML0127 commented on code in PR #3658:
URL: https://github.com/apache/flink-cdc/pull/3658#discussion_r1845349530
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/main/java/org/apache/flink/cdc/connectors/mysql/source/MySqlDataSourceOptions.java:
##########
@@ -272,4 +272,12 @@ public class MySqlDataSourceOptions {
+ "The difference between
scan.newly-added-table.enabled and scan.binlog.newly-added-table.enabled
options is: \n"
+ "scan.newly-added-table.enabled: do
re-snapshot & binlog-reading for newly added table when restored; \n"
+ "scan.binlog.newly-added-table.enabled:
only do binlog-reading for newly added table during binlog reading phase.");
+
+ @Experimental
+ public static final ConfigOption<Boolean> USE_LEGACY_JSON_FORMAT =
+ ConfigOptions.key("use.legacy.json.format")
+ .booleanType()
+ .defaultValue(true)
+ .withDescription(
+ "Whether to use legacy json format. The default
value is true, which means there is no whitespace before value and after comma
in json format.");
Review Comment:
`use.legacy.json.format` option for pipeline connector. default is `true`.
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/source/config/MySqlSourceOptions.java:
##########
@@ -262,4 +262,12 @@ public class MySqlSourceOptions {
.defaultValue(false)
.withDescription(
"Whether to skip backfill in snapshot reading
phase. If backfill is skipped, changes on captured tables during snapshot phase
will be consumed later in binlog reading phase instead of being merged into the
snapshot. WARNING: Skipping backfill might lead to data inconsistency because
some binlog events happened within the snapshot phase might be replayed (only
at-least-once semantic is promised). For example updating an already updated
value in snapshot, or deleting an already deleted entry in snapshot. These
replayed binlog events should be handled specially.");
+
+ @Experimental
+ public static final ConfigOption<Boolean> USE_LEGACY_JSON_FORMAT =
+ ConfigOptions.key("use.legacy.json.format")
+ .booleanType()
+ .defaultValue(true)
+ .withDescription(
+ "Whether to use legacy json format. The default
value is true, which means there is no whitespace before value and after comma
in json format.");
Review Comment:
`use.legacy.json.format` option for source connector. default is `true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
