SML0127 commented on code in PR #3658: URL: https://github.com/apache/flink-cdc/pull/3658#discussion_r1845340637
########## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/com/github/shyiko/mysql/binlog/event/deserialization/json/JsonStringFormatter.java: ########## Review Comment: I added `useLegacyJsonFormat` option as a static variable in [MySqlSourceConfig](https://github.com/apache/flink-cdc/blob/337b5de64f58041fff6383f76c103af54b7eec11/flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/source/config/MySqlSourceConfig.java#L69), and shared it with legcay [MySqlSource](https://github.com/apache/flink-cdc/blob/337b5de64f58041fff6383f76c103af54b7eec11/flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/MySqlSource.java#L161-L164) for legacy MySqlSource user. Also the default value of this option is `true`, so users who want to continue using current format(legacy format) don't need to worry about this new option. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
