LadyForest commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1521155291
########## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/FileSystemOutputFormat.java: ########## @@ -96,6 +99,22 @@ private FileSystemOutputFormat( this.outputFileConfig = outputFileConfig; this.identifier = identifier; this.partitionCommitPolicyFactory = partitionCommitPolicyFactory; + + createStagingDirectory(this.stagingPath); + } + + private static void createStagingDirectory(Path stagingPath) { + try { + final FileSystem stagingFileSystem = stagingPath.getFileSystem(); + Preconditions.checkState( + !stagingFileSystem.exists(stagingPath), + "Staging dir %s already exists", + stagingFileSystem); Review Comment: Nit: just noticed a typo that it should be `stagingPath` instead of `stagingFileSystem` at L#112 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org