XComp commented on code in PR #24390:
URL: https://github.com/apache/flink/pull/24390#discussion_r1521248255
##########
flink-connectors/flink-connector-files/src/test/java/org/apache/flink/connector/file/table/FileSystemOutputFormatTest.java:
##########
@@ -282,7 +278,7 @@ private FileSystemOutputFormat<Row> createSinkFormat(
TableMetaStoreFactory msFactory = new
FileSystemCommitterTest.TestMetaStoreFactory(path);
return new FileSystemOutputFormat.Builder<Row>()
.setMetaStoreFactory(msFactory)
- .setPath(path)
+ .setStagingPath(new Path(stagingPath.toString()))
Review Comment:
You can still stick to `setPath(stagingBasePath)` here and remove the
`stagingPath` field. The only thing you have to change is that you have to
assert for empty directory rather than deleted directory in
`checkWriteAndCommit`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
