LadyForest commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1520768668
########## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/FileSystemOutputFormat.java: ########## @@ -286,10 +302,21 @@ public Builder<T> setIsToLocal(boolean isToLocal) { } public Builder<T> setPath(Path path) { + return this.setStagingPath(toStagingPath(path)); + } Review Comment: Nit: to avoid arch rule being violated ```suggestion this.path = toStagingPath(path); return this; } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org