LadyForest commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1512605257
########## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/utils/PathUtils.java: ########## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.file.table.utils; + +import org.apache.flink.core.fs.FileSystem; +import org.apache.flink.core.fs.Path; +import org.apache.flink.util.Preconditions; + +import java.io.IOException; +import java.util.UUID; + +/** Path utils for file system. */ +public class PathUtils { + + public static Path getStagingPath(Path path) { Review Comment: I'm opting for option one as well. I didn't choose it in the first place because <1> Not very sure if it is tolerable to have duplicate logic scattered throughout the codebase. <2> I was hesitant about whether altering `FileSystemOutputFormat$Builder#setTempPath` to `FileSystemOutputFormat$Builder#setPath` might lead to any issues with dependencies. While I've manually reviewed the connector repositories and found no instances of the method being called, the impact on custom connectors remains unclear. Perhaps my concerns are a bit excessive. It appears that we're on the same page. I'll address the comment as we've discussed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
