davidradl commented on code in PR #79:
URL:
https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1463211057
##########
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcRowDataLookupFunction.java:
##########
@@ -71,7 +75,9 @@ public JdbcRowDataLookupFunction(
String[] fieldNames,
DataType[] fieldTypes,
String[] keyNames,
- RowType rowType) {
+ RowType rowType,
Review Comment:
it is used on line 108 this.jdbcRowConverter =
jdbcDialect.getRowConverter(rowType);
It looks like the field names are used to check that the key is a field,
then the field types to look up the key type.
Are you thinking of some more optimal way of doing this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
