davidradl commented on PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#issuecomment-1909958760
> for future: it is better not to squash commits unless it was requested explicitely by reviewer. The reason is that since there is no tool in GitHub confirming that the set of changes is same before and after sqaush then ideally need to go again through the changes and double check it... @snuyanzin OK, I see it makes review more difficult . I have been asked in the past to squash - as per [the process](https://cwiki.apache.org/confluence/display/FLINK/Merging+Pull+Requests), where is says `MUST squash fixup commits (for example commits that are addressing review comments).` I think it is pragmatic to follow what you say and only squash on the committers request. I notice in this process, it talks about back porting. Should I back port for this fix to the last connector release? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
