davidradl commented on PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#issuecomment-1905821215
> I noticed that there addressed only comment about `final` vars in `flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcRowDataLookupFunction.java` > > why we are talking about different branch btw? Which one is going to be merged? @snuyanzin I am not sure - I will bring @libenchao s branch into this branch then address your feedback; so we know where we are. I will leave the changes unsquashed until there is a good review from you both. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
