snuyanzin commented on code in PR #79:
URL:
https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1463273839
##########
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcRowDataLookupFunction.java:
##########
@@ -71,7 +75,9 @@ public JdbcRowDataLookupFunction(
String[] fieldNames,
DataType[] fieldTypes,
String[] keyNames,
- RowType rowType) {
+ RowType rowType,
Review Comment:
yes, however it could be calculated from `fieldNames` and `fieldTypes`
exactly in same way like it is done at lines 109-110
anyway this is just a thing to note, it seems not related to this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
