dmvk commented on code in PR #21981:
URL: https://github.com/apache/flink/pull/21981#discussion_r1120024257
##########
flink-tests/src/test/java/org/apache/flink/test/recovery/LocalRecoveryITCase.java:
##########
@@ -67,12 +68,14 @@
import java.util.Optional;
import java.util.concurrent.TimeUnit;
-import static org.assertj.core.api.Assertions.assertThat;
+import static org.junit.jupiter.api.Assertions.assertTrue;
/** Tests local recovery by restarting Flink processes. */
@ExtendWith(TestLoggerExtension.class)
class LocalRecoveryITCase {
Review Comment:
Thanks for the explanation, this makes perfect sense!
I'm trying the test locally, and it could be faster (not because of your
changes); it takes 23 seconds on the M1 Mac.
I'm wondering whether we need to start 3 TM subprocesses 🤔. Wouldn't be
enough to simply start in-process TMs (MiniCluster)? Wouldn't the AllocationID
logic remain unchanged (which is what we test for)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
