rkhachatryan commented on code in PR #21981:
URL: https://github.com/apache/flink/pull/21981#discussion_r1119952982


##########
flink-tests/src/test/java/org/apache/flink/test/recovery/LocalRecoveryITCase.java:
##########
@@ -67,12 +68,14 @@
 import java.util.Optional;
 import java.util.concurrent.TimeUnit;
 
-import static org.assertj.core.api.Assertions.assertThat;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 
 /** Tests local recovery by restarting Flink processes. */
 @ExtendWith(TestLoggerExtension.class)
 class LocalRecoveryITCase {

Review Comment:
   The test wasn't failing because the assertion failed the task, causing a 
restart; eventually, the right allocation ID would be picked up.
   I fixed it in 6c0284ca7bfe09a94740db27db38279234222c63 `[hotfix][tests] Make 
LocalRecoveryITCase fail when allocations don't match` by checking for any 
allocationID mismatches (in the main thread).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to