rkhachatryan commented on code in PR #21981: URL: https://github.com/apache/flink/pull/21981#discussion_r1119982866
########## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/allocator/VertexParallelism.java: ########## @@ -23,14 +23,27 @@ import java.util.Map; /** - * Core result of {@link SlotAllocator#determineParallelism(JobInformation, Collection)}, describing - * the parallelism each vertex could be scheduled with. - * - * <p>{@link SlotAllocator} implementations may encode additional information to be used in {@link - * SlotAllocator#tryReserveResources(VertexParallelism)}. + * Core result of {@link SlotAllocator#determineParallelism(JobInformation, Collection)} among with + * {@link org.apache.flink.runtime.scheduler.adaptive.JobSchedulingPlan.SlotAssignment + * slotAssignments}, describing the parallelism each vertex could be scheduled with. */ -public interface VertexParallelism { - Map<JobVertexID, Integer> getMaxParallelismForVertices(); +public class VertexParallelism { Review Comment: Good point, I'll adjust the interface and its javadoc. 4b5987c1da0c34069e029c00e5d891ae3261fef9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org