dmvk commented on code in PR #21981:
URL: https://github.com/apache/flink/pull/21981#discussion_r1122833790


##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/CreatingExecutionGraph.java:
##########
@@ -143,7 +143,7 @@ private void handleExecutionGraphCreation(
             } else {
                 logger.debug(
                         "Failed to reserve and assign the required slots. 
Waiting for new resources.");
-                context.goToWaitingForResources();
+                context.goToWaitingForResources(null);

Review Comment:
   🤔 Looking back on Chesnay's comment [1] Is passing null here correct? If 
not, I'd rather mark it as a bug and follow up in a separate PR to get things 
moving.
   
   [1] https://github.com/apache/flink/pull/21981#pullrequestreview-1307055034



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to